<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""> <div class="">Every emit function returns perl-code as a string, so also $fixer->emit_walk_path.</div> <div class=""><br class=""> </div> <div class="">"$perl" at the end should be removed, so that the return of "$fixer->emit_walk_path" is used as the return of this fix.</div> <div class="">"$perl .= " should be removed</div> <div class=""><br class=""> </div> <div class="">e.g.</div> <div class=""><br class=""> </div> <div class=""> <blockquote type="cite" class=""> <div class="WordSection1" style="page: WordSection1;"> <div class="" style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"> <span lang="EN-US" class="">$perl .= "if (is_string(${var})) {" .<o:p class=""></o:p></span></div> <div class="" style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"> <span lang="EN-US" class=""> "${add_value} = ${var};" .<o:p class=""></o:p></span></div> <div class="" style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"> <span lang="EN-US" class=""> "}";</span></div> </div> </blockquote> <br class=""> </div> <div class="">should be</div> <div class=""><br class=""> </div> <div class=""> <blockquote type="cite" class=""> <div class="WordSection1" style="page: WordSection1;"> <div class="" style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"> <span lang="EN-US" class=""> "if (is_string(${var})) {" .<o:p class=""></o:p></span></div> <div class="" style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"> <span lang="EN-US" class=""> "${add_value} = ${var};" .<o:p class=""></o:p></span></div> <div class="" style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;"> <span lang="EN-US" class=""> "}";</span></div> </div> </blockquote> </div> <div class=""><br class=""> </div> <div class=""><br class=""> </div> <br class=""> <div> <blockquote type="cite" class=""> <div class="">On 1 Jun 2017, at 07:42, Klee, Carsten <<a href="mailto:Carsten.Klee@sbb.spk-berlin.de" class="">Carsten.Klee@sbb.spk-berlin.de</a>> wrote:</div> <br class="Apple-interchange-newline"> <div class=""> <div class="WordSection1" style="page: WordSection1; font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> Hi Catmanduers!<o:p class=""></o:p></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <o:p class=""> </o:p></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">I’m trying to create a custom fix. Let’s call it my_add for a start.<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">The first thing I want to do is simply get a value (‘bar’) from a document:<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">{"foo": ["bar"]}<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">This is my fix:<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">package Catmandu::Fix::my_add;<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">use Catmandu::Sane;<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">use Moo;<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">use Catmandu::Fix::Has;<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">has value => ( fix_arg => 1 );<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">sub emit {<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""> my ( $self, $fixer ) = @_;<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""> my $add_value = $fixer->generate_var;<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""> my $perl = $fixer->emit_declare_vars( $add_value );<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""> my $path = $fixer->split_path( $self->value );<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""> my $key = pop @$path;<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""> $fixer->emit_walk_path($fixer->var, $path, sub {<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""> my $var = shift;<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""> $fixer->emit_get_key($var, $key, sub {<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""> my $var = shift;<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""> $perl .= "if (is_string(${var})) {" .<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""> "${add_value} = ${var};" .<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""> "}";<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""> });<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""> });<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""> $perl;<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">}<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">1;<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">Now fixing:<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">echo '{"foo": ["bar"]}'|catmandu -I lib convert JSON --fix "my_add(foo.0)"<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">But this ends with an error:<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">Oops! Global symbol "$__6" requires explicit package name at (eval 151) line 1.<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">DataDumper prints the Perl code as:<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">"my $__5;if (is_string($__6->{"0"})) {$__5 = $__6->{"0"};}if (is_string($__6->[0])) {$__5 = $__6->[0];}"<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">Which looks fine for me.<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">I also tried something different:<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">echo '{"foo": ["bar"]}'|catmandu -I lib convert JSON --fix "my_add(foo.$first)"<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">Now there is no error, but $key is now ‘foo’ and @$path is an empty list. It looks like ‘$first’ vanishes on the way to the fix.<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">Has anybody an idea what I’m doing wrong?<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class="">Thanks!<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span lang="EN-US" class=""><o:p class=""> </o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span class="">Carsten<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span class="">---<br class=""> Carsten Klee<br class=""> Zeitschriftendatenbank (ZDB)<br class=""> Staatsbibliothek zu Berlin – Preußischer Kulturbesitz<br class=""> <br class=""> Potsdamer Straße 33<br class=""> 10785 Berlin<br class=""> <br class=""> Tel.: +49 30 266-43 44 02<br class=""> Fax: +49 30 266-33 44 01<o:p class=""></o:p></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <span class=""><a href="mailto:carsten.klee@sbb.spk-berlin.de" style="color: purple; text-decoration: underline;" class="">carsten.klee@sbb.spk-berlin.de</a><br class=""> <a href="http://www.staatsbibliothek-berlin.de/" style="color: purple; text-decoration: underline;" class="">www.staatsbibliothek-berlin.de</a><b class=""><o:p class=""></o:p></b></span></div> <div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""> <o:p class=""> </o:p></div> </div> <span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">_______________________________________________</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> <span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">librecat-dev mailing list</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> <span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">- send list mails to<span class="Apple-converted-space"> </span></span><a href="mailto:librecat-dev@lists.uni-bielefeld.de" style="color: purple; text-decoration: underline; font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">librecat-dev@lists.uni-bielefeld.de</a><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> <span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">- to unsubscribe or change options, visit<span class="Apple-converted-space"> </span></span><a href="https://lists.uni-bielefeld.de/mailman2/cgi/unibi/listinfo/librecat-dev" style="color: purple; text-decoration: underline; font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">https://lists.uni-bielefeld.de/mailman2/cgi/unibi/listinfo/librecat-dev</a><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> <span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">- project website:<span class="Apple-converted-space"> </span></span><a href="http://librecat.org/" style="color: purple; text-decoration: underline; font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">http://librecat.org/</a></div> </blockquote> </div> <br class=""> </body> </html>