<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang="DE" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi Nicolas!<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">This seems to limit the fix I want to create to return just a value, right? But I want to emit code in the end. Can I use this within a ‘emit’ function?<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Cheers!<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Carsten<o:p></o:p></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"> <p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">Von:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Nicolas Steenlant [mailto:Nicolas.Steenlant@UGent.be] <br> <b>Gesendet:</b> Freitag, 2. Juni 2017 09:48<br> <b>An:</b> Klee, Carsten<br> <b>Betreff:</b> Re: [librecat-dev] convenience emit function<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Hi Carsten, <o:p></o:p></p> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">you can base your fix on this role for this common case:<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal"><a href="https://github.com/LibreCat/Catmandu/blob/master/lib/Catmandu/Fix/SimpleGetValue.pm">https://github.com/LibreCat/Catmandu/blob/master/lib/Catmandu/Fix/SimpleGetValue.pm</a><o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">Regards,<o:p></o:p></p> </div> <div> <p class="MsoNormal">Nicolas<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Helvetica","sans-serif";color:black">--<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Helvetica","sans-serif";color:black">Nicolas Steenlant<o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:9.0pt;font-family:"Helvetica","sans-serif";color:black">software developer at University Library Ghent<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <p class="MsoNormal">On 2 Jun 2017, at 09:42, Klee, Carsten <<a href="mailto:Carsten.Klee@sbb.spk-berlin.de">Carsten.Klee@sbb.spk-berlin.de</a>> wrote:<o:p></o:p></p> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Hi Catmanduers again!<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> <o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif"">I’m not sure that this is reasonable. But for me it seems like, when creating a fix, you have recurrent tasks like “get me a value from a given path”, “set a value for a given path” or “delete value for a given path”.</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif"">To achieve this you always have to write code like:</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif"">my $my_var = $fixer->generate_var;</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif"">my $perl = $fixer->emit_declare_vars($my_var );</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif"">my $path = $fixer->split_path( $self->path );</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif"">my $key = pop @$path;</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif"">$perl .=<span class="apple-converted-space"> </span></span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> $fixer->emit_walk_path($fixer->var, $path, sub {</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> my $var = shift;</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> $fixer->emit_get_key($var, $key, sub {</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> my $var = shift;</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> "if (is_string(${var})) {" .</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> "${my_var} = ${var};" .</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> "}";</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> });</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif"">But wouldn’t it be more convenient (and less error prone) to provide functions for such recurrent tasks? Like</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif"">my $perl = $fixer->emit_get_string(‘my_var’, $path, $fixer->var);</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif"">which should do the same like the code above. Or</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif"">my $perl = $fixer->emit_get_value(‘my_var’, $path, $fixer->var);</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif"">which also should do the same, but without the ‘is_string’ check.<span class="apple-converted-space"> </span></span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">And the same for emit_set_* and emit_delete_*.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> <o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Cheers!<span class="apple-converted-space"> </span><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> <o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Carsten<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">---<br> Carsten Klee<br> Zeitschriftendatenbank (ZDB)<br> Staatsbibliothek zu Berlin – Preußischer Kulturbesitz<br> <br> Potsdamer Straße 33<br> 10785 Berlin<br> <br> Tel.: +49 30 266-43 44 02<br> Fax: +49 30 266-33 44 01<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><a href="mailto:carsten.klee@sbb.spk-berlin.de"><span style="color:purple">carsten.klee@sbb.spk-berlin.de</span></a><br> <a href="http://www.staatsbibliothek-berlin.de/"><span style="color:purple">www.staatsbibliothek-berlin.de</span></a><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> <o:p></o:p></span></p> </div> <p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Helvetica","sans-serif"">_______________________________________________<br> librecat-dev mailing list<br> - send list mails to<span class="apple-converted-space"> </span></span><a href="mailto:librecat-dev@lists.uni-bielefeld.de"><span style="font-size:9.0pt;font-family:"Helvetica","sans-serif";color:purple">librecat-dev@lists.uni-bielefeld.de</span></a><span style="font-size:9.0pt;font-family:"Helvetica","sans-serif""><br> - to unsubscribe or change options, visit<span class="apple-converted-space"> </span></span><a href="https://lists.uni-bielefeld.de/mailman2/cgi/unibi/listinfo/librecat-dev"><span style="font-size:9.0pt;font-family:"Helvetica","sans-serif";color:purple">https://lists.uni-bielefeld.de/mailman2/cgi/unibi/listinfo/librecat-dev</span></a><span style="font-size:9.0pt;font-family:"Helvetica","sans-serif""><br> - project website:<span class="apple-converted-space"> </span></span><a href="http://librecat.org/"><span style="font-size:9.0pt;font-family:"Helvetica","sans-serif";color:purple">http://librecat.org/</span></a><o:p></o:p></p> </div> </blockquote> </div> <p class="MsoNormal"><o:p> </o:p></p> </div> </div> </div> </body> </html>